The rename of the Node is not valid because the display information is the label, so it looks strange press F2, rename and nothing happens.
This patch renames the label.
Still there is a problem with the default material of default Cube.
Edit: It looks the default material node is fixed. I think I looked at the wrong place before.
We should not just make labels equal to names. That breaks the feature where a node label automatically changes to match the operation in e.g. a math node.
I think the F2 operator should put the name in the text field instead of leaving it empty, and not change anything else.
@Brecht Van Lommel (brecht) You mean don't copy the name to label, so remove versioning_280.c and node.c code, right?
Mabe I miss something, but F2 now it's not an operator, but a simple property. I don't know how set the value to property in python, maybe I need add C code in RNA for "label" property to fill it with name if it's empty.
I think it seems alright.
Although one question is still with nodes like the math node. Currently it seems like it still works correctly, but the Label field doesn't update:
IMO this is no worse than before, when the Label field was simply blank in this case, so I think it seems like a good change overall.
@Brecht Van Lommel (brecht) thoughts?