Page MenuHome

Fix T54113: Render Artifacts with Motion Blur & Spacial Splits
AcceptedPublic

Authored by MATILLAT Quentin (qmatillat) on May 21 2019, 10:47 AM.

Details

Summary

Fix T54113.

Some artifact appear when rendering with Motion Blur & Spacial Split (see T54113 for example & minimal not working blend file).
The fix is to add a loop for each motion step in the function split_triangle_primitive

Diff Detail

Repository
rB Blender

Event Timeline

Nice catch!

intern/cycles/bvh/bvh_split.cpp
355

Think we should indeed switch to nullptr, but currently Cycles uses old-style NULL. Probably better be consistent for now and do the switch in the whole source base (making it even possible to use nullptr in the kernel code).

Replaced nullptr by old NULL

Can't spot any mistakes, tests are passing, verified that report is fixed.

@Stefan Werner (swerner), anything from your side?

@MATILLAT Quentin (qmatillat), did you set up your account to be able to commit and such (Bastien mailed the list about this recently) ?

This revision is now accepted and ready to land.May 21 2019, 4:25 PM
MATILLAT Quentin (qmatillat) marked an inline comment as done.May 21 2019, 6:31 PM

I have setup my git access.

BTW, I was wondering if the same issue was applicable to curve. I'm not sure if motion blur can be used on curve, but in that case, I think we have the same issue on curve (in split_curve_primitive).

Looks good to me.
We should do the same for curves, I think.