Page MenuHome

Make masking in Image Editor consitent with masking in Clip Editor
ClosedPublic

Authored by Sebastian Koenig (sebastian_k) on Jun 20 2019, 5:43 PM.

Details

Summary

This patch tries to make masking UI in Image Editor match masking in Clip Editor as close as possible.

  1. The Mask Display menu is now part of the header just like in MCE
  2. The mask options are no longer part of Image category but now have their own Mask tab
  3. When you are in Mask mode you can call the same masking context menu just like in MCE

What's missing are the tools themselves, which are in the old toolshelf are in MCE, but since we do have active tools in image editor, the only option would be to put them in the sidebar on the right. So I am leaving those out.

I know it's a bit late and UI is frozen already, but since those options in MCE just got into master yesterday I figured it should be fine :)

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Jun 21 2019, 11:49 AM
Brecht Van Lommel (brecht) added inline comments.
release/scripts/startup/bl_ui/space_image.py
788

This should be in poll() so the menu is not opened at all, instead of opening an empty menu.

789

Use layout.operator_menu_enum("mask.handle_type_set", "type"), don't need to create a IMAGE_MT_mask_handle_type_menu.

This revision now requires changes to proceed.Jun 21 2019, 11:49 AM

I have removed the extra class and added a poll.
While doing the poll function I figured it would make sense to make the context menu aware of if there is a mask or not, so you can create an empty new mask or add a new mask with primitive shape from the context menu.

This revision is now accepted and ready to land.Jun 27 2019, 7:09 PM