Page MenuHome

UI: Proposal for Simplified Editor Menu
ClosedPublic

Authored by Harley Acheson (harley) on Jun 26 2019, 2:40 AM.

Details

Summary

Not sure if anyone would be interested in this.

I just find that the current Editor Menu is a bit more visually confusing than it has to be. I find the title to be unnecessary, and it has a line going a quarter-way across the widow. Categories are shown but they don't seem obvious enough what they are, and the close proximity to the list makes them seem horizontally misaligned. Possibly all just personal preference, but I thought I'd let mine known.

Following shows these changes affect the Editor menu, Languages, and Image File Format:

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Jun 26 2019, 3:05 AM

There has been discussion about removing the property name from these types of dialogs. That may be ok if we agree on it.

Doing it by removing the name of properties is not ok, all properties must have valid names.

This revision now requires changes to proceed.Jun 26 2019, 3:05 AM

This revision takes away the need to alter the property in rna_screen.c

Instead if the list contains categories then show them with rules below them and don't show the title. A bit simpler this way.

@Brecht Van Lommel (brecht) : Doing it by removing the name of properties is not ok, all properties must have valid names

Yes, I realized that was dumb when I found another multi-column list (Languages).
And then took that out before I noticed you mention it. LOL

Had to make changes to support lists with categories where the items in a section overflow to the next column

For example, the top of the following image shows the "Languages" list as it is currently. The "Starting" section is so long that it overflows and shows "Polish" on the same row as the category titles.

The bottom of the image above shows how is looks after this patch is applied. No title, and the overflowing category still looks nice.

This is definitely an improvement for cases where we have overflowing columns, as the last image shows.

If the technical side is ok, I think we should make this change.

Updated to current state of master.

A new sample:

Updating for current state of master and to simplify it a bit.

I like the changes here too. I think Campbell would be the one to check on the code side though.

source/blender/editors/interface/interface.c
4058

I would recommend an explicit comparison to 0 here so it's clear the variable is an int.

Harley Acheson (harley) edited the summary of this revision. (Show Details)

Updated to current state of master and to incorporate suggestions by @Hans Goudey (HooglyBoogly)

Updated to current state of master.

Totally forgot about this one too. +1 for sure!

I like the line dividing the categories, would this also apply do the Modifiers list? (this is master, couldn't test this patch yet)

@Pablo Vazquez (pablovazquez) - ...would this also apply do the Modifiers list? (this is master, couldn't test this patch yet)

No, that list is made in some other way (doesn't use ui_def_but_rna__menu). This change makes the other lists more like the Modifier list since it it removes the "Title" if there are categories. So, for example removing that "Editor Type" we see the top of that list.

But yes, we'd just have to add that divider line under the categories in the Modifiers list and they would look the same. Now I just have to find that thing...

@Pablo Vazquez (pablovazquez) - Added a rule inside uiItemsFullEnumO_items() so that the "Modifiers List" looks the same as the others:

You know what, I'm always wondering why the "scripting" column comes first than the "data" column (left to right)... I'd swap those two sections and make the "scripting" the last one, since it's the least used section, I think?
But hey, that's just me... lol...

@Pablo Vazquez (pablovazquez) - Added a rule inside uiItemsFullEnumO_items() so that the "Modifiers List" looks the same as the others:

Great, thanks! To me this is good to go from the UI side of things.

This revision is now accepted and ready to land.Mon, Oct 19, 2:14 PM

But hey, that's just me... lol...

No, it's not just you.

@TheRedWaxPolice (TheRedWaxPolice) ... I'd swap those two sections and make the "scripting" the last one

Yes, me too. But there’s no way I’d touch that with a ten foot pole as the “muscle memory” crowd would have me in a pillory.

Yes, me too. But there’s no way I’d touch that with a ten foot pole as the “muscle memory” crowd would have me in a pillory.

I doubt people will even notice it... hehehe..

This revision was automatically updated to reflect the committed changes.