Page MenuHome

Fix T64149: Texture paint can act as a canvas and brush at the same time
ClosedPublic

Authored by Sebastian Parborg (zeddb) on Jul 9 2019, 2:26 PM.

Details

Summary

I don't know if it was the intended behavior or not, but having brush and canvas data at the same time with dymanic paint, would lead to the object trying to act as a brush and a canvas at the same time.

We can't currently handle this with the new depsgraph, and it could legitimately lead to bad feedback loops.

So now, to be more consistent with the GUI, I've made it only use the current set type (brush or canvas) as the final type of the object.
That is, you can only have a object be a brush or a canvas, not both at the same time.

Diff Detail

Event Timeline

From reading the code, seems fine.

If we ever want to support same object to be a brush and canvas, this would need to be done as an explicit solver step, otherwise result would depend on evaluation order which we can not guarantee.

This revision is now accepted and ready to land.Jul 9 2019, 2:34 PM

Gah, forgot to add the review information in the commit :/