Page MenuHome

Fix T67008: Missing move handle and flickering in FileBrowser
ClosedPublic

Authored by Andrea Weikert (elubie) on Jul 16 2019, 11:37 PM.

Details

Summary

Fix T67008: Missing move handle and flickering in FileBrowser

Allow split regions (child regions) to contribute to the action zones (azone) of the parent region.
This fixes the issues in file browser and also in the user preferences.

Diff Detail

Repository
rB Blender

Event Timeline

Bastien Montagne (mont29) accepted this revision.

Thanks for the patch! It seems to work nicely, and I cannot find anything wrong in its code. But am really not familiar with that area (haha) of the UI code, so would not mind if @Campbell Barton (campbellbarton) or @Brecht Van Lommel (brecht) could also have a look at it?

This revision is now accepted and ready to land.Sun, Jul 21, 3:32 PM

I'm probably the one who did most changes for 2.80 in relating code. And I didn't remember ever seeing special treatment of split regions, which made me wonder how this could ever work before.
Turns out we added the AZone's during region size updating, at a point where the prev region was temporarily using a winrct of both regions combined. So of course a single AZone spanning both regions would be added.

Given that we've now separated region resizing from AZone creation, this kind of special treatment makes sense. Didn't test, but the code seems to handle everything needed.

Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/screen/area.c
1055–1058

Screen is an unused argument.

source/blender/editors/screen/screen_ops.c
2489–2490

Use * prefix for comment blocks.