Page MenuHome

Brush Gradient UI tweak
ClosedPublic

Authored by William Reynish (billreynish) on Thu, Aug 1, 3:49 PM.

Details

Summary

This is a fairly small tweak to the brush UI.

The brush Gradient option renders the color field invalid. The two are mutually exclusive. The trouble is that when looking at the UI, this is entirely not obvious, because the UI is currently misleading. It makes it seem as if you can enable the Gradient in addition to setting a color, which is not the case.

When enabling the Gradient option, the color just greys out, but with a simple UI change, this can become clearer, and more compact.

Before:

After:


Diff Detail

Repository
rB Blender

Event Timeline

William Reynish (billreynish) edited the summary of this revision. (Show Details)

I noticed a technical problem:

The color ramp UI widget itself is not shown. Before, this would only get initialized when you enabled the use_gradient boolean. The strange thing is that I am still using the same DNA entry (BRUSH_USE_GRADIENT) so I don't understand why this no longer workd correctly

Fixed tooltip (copy/paste mistake)

Fixed the gradient color ramp not appearing (was missing the reference to rna_Brush_use_gradient_set)

This is now ready for review

William Reynish (billreynish) edited the summary of this revision. (Show Details)

The patch was affecting Vertex Paint mode also, now it only affects Texture Paint, which is the only place the Gradient option actually works.

Much better this way.

This revision is now accepted and ready to land.Fri, Aug 2, 4:13 AM
This revision was automatically updated to reflect the committed changes.