Page MenuHome

Shading: Extend Musgrave node to other dimensions.

Authored by Omar Emara (OmarSquircleArt) on Aug 23 2019, 9:54 AM.



This patch extends Musgrave noise to operate in 1D, 2D, 3D, and 4D
space. The Color output was also removed because it was identical
to the Fac output.

This patch was created from the noise-node branch, and it depends on D5560.

Diff Detail

rB Blender

Event Timeline

  • Update versioning code.

This patch was supposed to depend on D5560, but apparently the commits from D5560 are now in this patch as well. So, I am not entirely sure what to do now.

Omar Emara (OmarSquircleArt) planned changes to this revision.Sep 4 2019, 7:10 PM

Merge master and update patch.

Omar Emara (OmarSquircleArt) planned changes to this revision.Sep 4 2019, 9:17 PM

The musgrave code needs to refactored to avoid writing to inputs and to follow best practices, in particular, we want the declarations to be closer to the initializations and limit the scope of variables.

  • Refactor musgrave code.
Brecht Van Lommel (brecht) requested changes to this revision.Sep 9 2019, 4:09 PM

Looks good overall.


Check if link->fromnode && here, this can be NULL in some cases and causes automated tests to crash.

This revision now requires changes to proceed.Sep 9 2019, 4:09 PM
  • Update patch and merge master.
Omar Emara (OmarSquircleArt) marked an inline comment as done.Sep 9 2019, 7:57 PM
  • Bump the subversion because of 55245ed6ad72.
This revision is now accepted and ready to land.Sep 9 2019, 8:04 PM