Page MenuHome

Fix T69542: Corrective Smooth modifier breaks when drivers are involved.
Needs ReviewPublic

Authored by Sebastian Parborg (zeddb) on Thu, Sep 5, 5:10 PM.

Details

Summary

Previously the cache for the modifier would not be invalidated if modifier settings were changed with drivers or keyframes.

Now we compare the current setting with the ones used to generate the cache and invalidate the cache if they differ.

Diff Detail

Event Timeline

Sergey and I noticed that this will still break if the vertex count of the mesh is the same (but not the topology) or if the input vertex weight group is animated.
However, we deemed that these use cases are not that common and we are unsure if it would be worth to try to guard against these issues at this point in time.

This is because we would have to store the caches mesh topology and vertex weights to be able to check this. (Or somehow boil them down into a hash). But then we would have to calculate this hash on each frame from the current mesh data anyways.