Page MenuHome

Sculpt: Split original normal into original normal and plane
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Sep 16 2019, 6:41 PM.
Tags
None
Tokens
"100" token, awarded by Frozen_Death_Knight."Love" token, awarded by xrg."Love" token, awarded by JulienKaspar.

Details

Summary

This allows to create different effects with some brushes that use the sculpt plane

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Sep 17 2019, 9:19 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/blenloader/intern/versioning_270.c
1749–1750

First thought was to not reuse old flags, but these flags have been unset already since a long time.
So current implementation is acceptable as long as we comment the do_versioning part.

It is currently unclear what these flags have to do with falloff_angle.

Note: We could free some flags by moving the pressure flags from eBrushFlags to BrushMaskPressureFlags, but that will break file compatibility, that can be avoided by introducing more space in a separate flag.

source/blender/editors/sculpt_paint/sculpt.c
4288–4293

Seems like we could limit a copy.

if ((!ss->cache->first_time) && (brush->flag & BRUSH_ORIGINAL_NORMAL)) {
} else {
}
4296–4301

Same here

This revision now requires changes to proceed.Sep 17 2019, 9:19 AM
Pablo Dobarro (pablodp606) marked 3 inline comments as done.
  • Review update
This revision is now accepted and ready to land.Sep 18 2019, 8:14 AM