Page MenuHome

Sort list of .dat files
Needs RevisionPublic

Authored by Bernhard M. Wiedemann (bmwiedemann) on Fri, Sep 20, 9:28 AM.

Details

Summary

Sort list of .dat files
in .png generation to make builds reproducible.
See https://reproducible-builds.org/ for why this matters.

Note: scandir is only available on POSIX-compliant platforms (Linux,
BSD, MacOSX, cygwin) - so others would need some compat layer.

Diff Detail

Repository
rB Blender
Branch
readdir (branched from master)
Build Status
Buildable 5046
Build 5046: arc lint + arc unit

Event Timeline

Bastien Montagne (mont29) requested changes to this revision.Fri, Sep 20, 5:09 PM

This is not acceptable, we need that code to run on all of our supported OSs… Think I’d rather go with filling an array of pointers to strings, use qsort on it, and then merge the icons in a second loop over that array of char pointers…

This revision now requires changes to proceed.Fri, Sep 20, 5:09 PM