Page MenuHome

Sculpt: Sculpt cursor UX improvements
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Sep 24 2019, 11:27 PM.
Tags
None
Tokens
"Love" token, awarded by Alrob."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by xrg."Love" token, awarded by jmztn."Love" token, awarded by Zino."Love" token, awarded by CobraA."Love" token, awarded by wilBr."Love" token, awarded by MetinSeven."Love" token, awarded by HARDNAX."Love" token, awarded by Tonatiuh."Mountain of Wealth" token, awarded by Way."Love" token, awarded by kioku.

Details

Summary

This patch introduces the following changes:

  • Invert the direction of the brush strength WM control. It was working in the opposite direction to any other control in Blender. Now dragging to the right increases the strength.
  • Increase the alpha of the cursor
  • Remove the font shadow of the numbers in the WM control. It was adding too much visual noise when rendered on top of the brush alpha
  • Add a second circle to preview the strength in the cursor
  • Increase the resolution of the cursor circles. Now they look smooth even when working with large brush sizes.

Diff Detail

Repository
rB Blender

Event Timeline

  • Minor tweaks
  • Increase font size
  • Hide curve texture when resizing if there is no texture enabled
  • Fix circle contrast
Way awarded a token.Sep 25 2019, 10:54 AM
  • Add curve line preview

  • Increase resolution of curve texture

@Jeroen Bakker (jbakker) Is it ok to increase the resolution of the preview texture? That improves the quality of the edges when previewing a curve with a sharp falloff

Tested. All these changes make a surprisingly big positive difference.

  • Invert the direction of the brush strength WM control: This makes the strength work as expected - the larger the ring, the higher the strength.
  • Increase the alpha of the cursor: No idea why it was previously transparent, but it was often very hard to see. This helps a lot.
  • Add a second circle to preview the strength in the cursor: Probably the most controversial addition. I think it's ok on balance, given that it's more faded than the main brush circumference circle
  • Increase the resolution of the cursor circles: They were just slightly too low before, giving you a polygonal circle line instead of a smooth circle. This is much preferred.
  • Increase resolution of curve texture: This really helps a lot, especially for sharp falloffs where the previous low resolution was very jaggy
This revision is now accepted and ready to land.Sep 25 2019, 6:11 PM
  • Make curve less white
  • Show curve only when changing strength

Could I make a suggestion, Pablo? Could you possibly add more previews of activated brush settings as an R click option? Things like Colour, Smooth Stroke, Accumulate, Original Normal, and more in a simplified, floating list. You could also add the new Falloff preview there, since someone on the BlenderArtists forum thought that the new Falloff preview on the brush cursor itself was a bit too big and distracting. Would make a bit more sense to have a unified preview box showing all of the active settings instead of putting them on the brush cursor itself.

Personally, I really like the new Falloff preview, but I can understand if some would find it too much.

  • Hide gradient when resizing

Followed progress - the updates are fine with me.

I have to say that falloff preview looks rather distracting... not sure if that's necessary. One look to the top (or right) is enough to remind the user which falloff they've selected, if that's the intended use (?). Apart from that I like the changes. The strength direction being reversed will take some getting used to, but makes more sense. Those little tweaks really obviously come from a sculptor !

CobraA (CobraA) added a subscriber: CobraA (CobraA).

Since this is about Cursor UX could you find a solution to make resizing the brush Cursor starts alawys from the center instead of the Outer ring? thanks.

Since this is about Cursor UX could you find a solution to make resizing the brush Cursor starts alawys from the center instead of the Outer ring? thanks.

@Pablo Dobarro (pablodp606) I agree. Perhaps it would be good to have the cursor not jump when increasing the size/strength. This makes it easier to match the desired radius with the model in the background (For example matching the size to the pupil for painting an eye.
We could move the mouse right/up to increase and left/down to decrease and leave the cursor centred.

  • Don't offset the cursor preview when changing size and strength

BKE_brush_gen_radial_control_imbuf is now generating 16x more pixels, which could become a bottleneck, though it's only computed once when starting radial control.

It would be good to multithread this one day, but I guess we'll see if it's an issue.

This revision was automatically updated to reflect the committed changes.