Page MenuHome

DrawManager: Disable Clipping in material/rendered mode
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Oct 11 2019, 7:04 AM.

Details

Summary

Viewport: Disable Clipping For EEVEE and External Renderers

Currently it is possible that, when using viewport clipping, the display and tools communicate
different information to the user then the renderer does. The reason is
that the renderer does not support viewport clipping. Both EEVEE and
Cycles do not support it.

This patch will disable the clipping in all the tools and drawing code
when the viewport drawing mode is Material Preview or Rendered.

This patch introduces a RV3D_CLIPPING_ENABLED util that checks if
clipping is enabled for the given rv3d and v3d. Also in places where
it was needed we added the ViewContext as a carrier for the View3D
and RegionView3D.

There are a few areas in the tooling (select, projection painting) that
still needs to be tackled after this patch.

Diff Detail

Repository
rB Blender
Branch
T70512 (branched from master)
Build Status
Buildable 5331
Build 5331: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) retitled this revision from Do now show viewport clipping when in material or rendered mode to [WIP] Do now show viewport clipping when in material or rendered mode.Oct 11 2019, 7:04 AM

Moved code to DNA_view_types as a define

Adding clip border to determine if we need to show the clipping

Jeroen Bakker (jbakker) retitled this revision from [WIP] Do now show viewport clipping when in material or rendered mode to DrawManager: Disable Clipping in material/rendered mode.Oct 11 2019, 10:05 AM
Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)
Jeroen Bakker (jbakker) planned changes to this revision.Wed, Nov 27, 12:20 PM

Redo with new unified overlays

Migrated to new overlay engine

In previous diff I missed one file I wanted to revert. This diff reverts that file

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Tue, Dec 10, 4:00 PM
Clément Foucault (fclem) added inline comments.
source/blender/draw/engines/workbench/workbench_data.c
126–130

is that ok during rendering?

This revision is now accepted and ready to land.Wed, Dec 11, 1:04 PM
Jeroen Bakker (jbakker) marked an inline comment as done.Wed, Dec 11, 4:53 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/draw/engines/workbench/workbench_data.c
126–130

Yes, RV3D_CLIPPING_ENABLED does the NULL checks.

This revision was automatically updated to reflect the committed changes.
Jeroen Bakker (jbakker) marked an inline comment as done.