Page MenuHome

Fix T70605: incorrect darken and lighten rgb mix mode

Authored by Jacques Lucke (JacquesLucke) on Oct 14 2019, 4:11 PM.

Diff Detail

rB Blender

Event Timeline

Can you fix node_mix.osl as well?

This revision is now accepted and ready to land.Oct 14 2019, 4:26 PM
Brecht Van Lommel (brecht) requested changes to this revision.Oct 14 2019, 4:26 PM
This revision now requires changes to proceed.Oct 14 2019, 4:26 PM

Hmm, MixLightenOperation::executePixelSampled also seems to be doing the same that the old mix_light was doing...

I guess this should be fixed as well then?

@Jacques Lucke (JacquesLucke) do one thing at a time. If the patch as it is fixes the reported issue, leave MixLightenOperation to be tackled separated.

@Clément Foucault (fclem) can you give this patch a +1?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 15 2019, 5:37 PM
This revision was automatically updated to reflect the committed changes.