Page MenuHome

Include Handles Box Selection in VSE
Needs RevisionPublic

Authored by Thijs van Berkel (ANMThijs) on Sun, Oct 27, 11:17 AM.

Details

Summary

This patch makes it possible to only select handles using box selection in the video sequencer, as described by this post: https://developer.blender.org/T70730

Diff Detail

Event Timeline

Maybe I'm using it wrong, but it seems to select both handles of selected strips(not correct), and not just the handles inside the box selection(correct), like the linked to add-on?

I think you're selecting too much of the sequence. I made the code so it divides a sequence into three smaller boxes. If the left side of the selection is in the right box, it'll only select the right handle. If the right side of the selection is in the left box, it'll only select the left handle. If any of the sides are in the box in the middle it'll select both.

I hope this helps :)

Thijs van Berkel (ANMThijs) changed the visibility from "Public (No Login Required)" to "No One".Sun, Oct 27, 4:26 PM
Thijs van Berkel (ANMThijs) changed the visibility from "No One" to "Public (No Login Required)".

I have made it so the system detects whether the start or the end of the sequence is inside the box selection, rather than creating 3 rectangles and detect if it inside one of those

This comment was removed by Peter Fog (tintwotin).
Richard Antalik (ISS) requested changes to this revision.Mon, Oct 28, 5:07 AM

In example addon operator was run with ctrl+b. Don't modify original function, make another mode of an operator and register it in keymap.
Deselect/append should work with shift and box-selecting handle so it would be ctrl++b

It is so much better now, however I noticed it is not possible to select one handle:

I guess that I agree.

I think that it would be much easier to 'limit' this operator mode to only selecting handles. After all selecting both handles has same effect as selecting strip itself.

This revision now requires changes to proceed.Mon, Oct 28, 5:07 AM
This comment was removed by Peter Fog (tintwotin).
Campbell Barton (campbellbarton) requested changes to this revision.Tue, Oct 29, 3:06 PM

I think that it would be much easier to 'limit' this operator mode to only selecting handles. After all selecting both handles has same effect as selecting strip itself.

If you select both handles then grab the strip to move it - the entry/exit points change, keeping the strip start at the same time.

As @Richard Antalik (ISS) suggests, think this should use Ctrl-B, this is what the F-Curve editor uses to select f-curve handles.

As this is very similar functionality it seems reasonable to use matching behavior.

Note that we're probably going to change the graph editor, so that Include Handles is enabled by default there, activated with B rather than Ctrl+B. See D6235.
Now, if that is good default for the VSE, I don't know.

Note that we're probably going to change the graph editor, so that Include Handles is enabled by default there, activated with B rather than Ctrl+B. See D6235.
Now, if that is good default for the VSE, I don't know.

as Campbell said,

If you select both handles then grab the strip to move it - the entry/exit points change, keeping the strip start at the same time.

That's not what user would expect. We could change logic of grab/move, but I will have to look at how other editors behave, when I select object with it's handles and move this selection, In case VSE is/will be inconsistent here.