Sculpt: Clay Strips Roundness property
Needs ReviewPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Oct 31 2019, 9:11 PM.

Details

Reviewers

Summary

This patch allow to change the brush tip shape between a square and a
circle using a brush property.

After this change we are no longer testing the distance against a cube
(the Z axis is not used). I did not test this in depth, but if it does
not produce any artifacts I think we can keep it this way instead of
adding more complexity to the code.

Diff Detail

Repository

rB Blender

Branch

clay-strips-roundness (branched from master)

Build Status

Buildable 5884
Build 5884: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Oct 31 2019, 9:11 PM

Harbormaster completed remote builds in B5515: Diff 19315.Oct 31 2019, 9:11 PM

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)Oct 31 2019, 9:12 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).

Pablo Dobarro (pablodp606) added a project: BF Blender (2.82).

Brandon (Brandon777) awarded a token.Oct 31 2019, 9:29 PM

Kenn Nyström (Frozen_Death_Knight) awarded a token.Oct 31 2019, 9:47 PM

Bartosz Moniewski (monio) awarded a token.Oct 31 2019, 10:44 PM

Maged afra (Maged_afra) awarded a token.Nov 1 2019, 12:39 AM

Maged afra (Maged_afra) rescinded a token.

Maged afra (Maged_afra) awarded a token.

Valeri Che (Dusty_Shoe) awarded a token.Nov 1 2019, 1:56 AM

srikanth (Alrob) awarded a token.Nov 1 2019, 3:53 AM

Tonatiuh de San Julián (Tonatiuh) awarded a token.Nov 1 2019, 11:19 PM

Metin Seven (MetinSeven) awarded a token.Nov 2 2019, 11:13 AM

Joseph Brandenburg (TheAngerSpecialist) awarded a token.Nov 5 2019, 10:51 PM

Do we need to add migration code. Seems like the setting is set to 0.25f I expected some sort of migration code.

Add versioning code

Harbormaster completed remote builds in B5689: Diff 19644.Fri, Nov 15, 12:10 AM

Rebase
Update defaults

Harbormaster completed remote builds in B5758: Diff 19802.Sun, Nov 24, 1:10 AM

Tiago Cruz (tiagoffcruz) awarded a token.Sun, Nov 24, 2:08 AM

AntoineR (S_Jockey) awarded a token.Mon, Nov 25, 6:47 PM

Pablo Dobarro (pablodp606) mentioned this in D5928: Brush Settings UI.Sat, Nov 30, 6:22 PM

Rebase

Harbormaster completed remote builds in B5884: Diff 20029.Tue, Dec 3, 4:02 AM

Evan Wilson (EAW) awarded a token.Sun, Dec 8, 1:40 AM

Revision Contents
Changeset List

			Path	Packages
M			release/scripts/startup/bl_ui/space_view3d_toolbar.py (3 lines)
M			source/blender/blenkernel/intern/brush.c (6 lines)
M			source/blender/blenkernel/intern/colortools.c (15 lines)
M			source/blender/blenloader/intern/versioning_280.c (8 lines)
M			source/blender/editors/sculpt_paint/sculpt.c (25 lines)
M			source/blender/editors/sculpt_paint/sculpt_intern.h (5 lines)
M			source/blender/makesdna/DNA_brush_types.h (4 lines)
M			source/blender/makesdna/DNA_color_types.h (1 line)
M			source/blender/makesrna/intern/rna_brush.c (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19315	44d67b6		Oct 31 2019, 9:11 PM	★	★
Diff 2	19644	44d67b6	- Add versioning code	Fri, Nov 15, 12:10 AM	★	★
Diff 3	19802	44f18ce	- Rebase	Sun, Nov 24, 1:10 AM	★	★
Diff 4	20029	a81fdef	- Rebase	Tue, Dec 3, 4:02 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
83fb4806414d	9c50deefa2c7	975c51fc0403	Pablo Dobarro	Rebase	Tue, Dec 3, 4:06 AM
975c51fc0403	384e08b21a2e	8a717d3d3190	Pablo Dobarro	Update defaults	Sun, Nov 24, 1:14 AM
8a717d3d3190	2dda2d32aaaa	052185cfdb22	Pablo Dobarro	Add versioning code	Fri, Nov 15, 12:13 AM
052185cfdb22	7a651551d9a0	a81fdefddebc	Pablo Dobarro	Sculpt: Clay Strips Roundness property (Show More…)	Oct 31 2019, 9:14 PM