Page MenuHome

Sculpt: Enable symmetrize operator with Dyntopo disabled
AcceptedPublic

Authored by Pablo Dobarro (pablodp606) on Sun, Nov 3, 11:07 PM.
Subscribers
None
Tokens
"Like" token, awarded by Brandon777."Like" token, awarded by MetinSeven."100" token, awarded by Frozen_Death_Knight.

Details

Summary

After refactoring the mirror modifier and supporting geometry modifications with PBVH_FACES this operator can be easily implemented without Dyntopo.

The symmetrize button and options are still in the Dyntopo pannel. There are patches like doing multiple modifications in the Sculpt mode UI, so we need to find a way to organize this better.

Diff Detail

Repository
rB Blender
Branch
sculpt-faces-symmetrize (branched from master)
Build Status
Buildable 5564
Build 5564: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Tue, Nov 5, 12:18 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
7576

Move this function to a the Dynamic topology symmetrize code. It is has nothing to do with optimize.

7613–7615

Don't call BKE_pbvh_type in every if. Just store it in a local variable and use that.
use a switch statement?

7690

This should also be done when pbvh type isn't known...

This revision now requires changes to proceed.Tue, Nov 5, 12:18 PM
Pablo Dobarro (pablodp606) marked 3 inline comments as done.
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)
  • Review Update
This revision is now accepted and ready to land.Wed, Nov 6, 12:40 PM