Avoid Brush user count increase when duplicates the Brush
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Tue, Nov 26, 7:11 PM.

Details

Reviewers

Commits

rB50128e8e79bf: Avoid Brush user count increase when duplicates the Brush

Summary

When you create a new Brush, the user count is 2 (caller and fake user). The problem is when you duplicate a Brush, the user count grows to 3 and IMHO this is not correct, because is a new brush.

Diff Detail

Repository: rB Blender

Event Timeline

Antonio Vazquez (antoniov) created this revision.Tue, Nov 26, 7:11 PM

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)Tue, Nov 26, 7:27 PM

Bastien Montagne (mont29) set the repository for this revision to rB Blender.Wed, Nov 27, 11:21 AM

Indeed, copy also add a default initial user, so patch LGTM.

This revision is now accepted and ready to land.Wed, Nov 27, 11:24 AM

Closed by commit rB50128e8e79bf: Avoid Brush user count increase when duplicates the Brush (authored by Antonio Vazquez (antoniov)). · Explain WhyWed, Nov 27, 11:31 AM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rB50128e8e79bf: Avoid Brush user count increase when duplicates the Brush.

Revision Contents
Changeset List

			Path	Packages
M			source/blender/editors/sculpt_paint/paint_ops.c (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19847			Tue, Nov 26, 7:07 PM	★	★
Diff 2	19873	0281411	rB50128e8e79bff560d0da6825663543c82286ab17	Wed, Nov 27, 11:29 AM	★	★

Diff 19873

View Options

source/blender/editors/sculpt_paint/paint_ops.c

Avoid Brush user count increase when duplicates the BrushClosedPublicActions