Page MenuHome

Fix T51828
Needs ReviewPublic

Authored by Eitan (EitanSomething) on Wed, Nov 27, 7:37 AM.

Details

Summary

This patch offsets removes scaling the movie strip when a proxy is used

  • TODO: check if the proxy actually exists

Diff Detail

Repository
rB Blender
Branch
Fix-T51828 (branched from master)
Build Status
Buildable 5824
Build 5824: arc lint + arc unit

Event Timeline

  • Update sequencer.c
  • Update sequencer.c
  • Update sequencer.c
  • Update sequencer.c
  • Update sequencer.c

I wonder if this one is related? https://developer.blender.org/T70415

I will look into it

Eitan (EitanSomething) planned changes to this revision.Wed, Nov 27, 5:53 PM

Doesn't work

  • Working Solution

I guess something like this could work, will have look into this in debug.

This diff doesn't revert rB450685b15664 actually
And there may be issue, that 50% proxy of clip that is 1000 x 1000 will be 500 x 500 regardless of what your project resolution is set to.

Eitan (EitanSomething) edited the summary of this revision. (Show Details)Thu, Nov 28, 2:46 AM

I guess something like this could work, will have look into this in debug.
This diff doesn't revert rB450685b15664 actually
And there may be issue, that 50% proxy of clip that is 1000 x 1000 will be 500 x 500 regardless of what your project resolution is set to.

I haven’t tested it but
The clip should scale to fit when the offset button is turned off,but when it I selected it will stay at 500 x 500

Eitan (EitanSomething) edited the summary of this revision. (Show Details)Thu, Nov 28, 3:33 AM
Eitan (EitanSomething) updated this revision to Diff 19919.EditedThu, Nov 28, 4:51 AM
  • Fix Cropping
Eitan (EitanSomething) edited the summary of this revision. (Show Details)Thu, Nov 28, 4:54 AM