Page MenuHome

convert all gl_FragColor variables to FragColor
Needs ReviewPublic

Authored by Jean First (robbott) on Dec 17 2019, 3:24 AM.

Details

Summary

if the commit D6424 is correct, maybe all gl_FragColor variables should be converted to FragColor.

Diff Detail

Repository
rB Blender
Branch
gl_fragcolor (branched from master)
Build Status
Buildable 6041
Build 6041: arc lint + arc unit

Event Timeline

D6424 fixed an openGL bug on macos.

This diff fixes at least the Python examples, I don’t know about opensubdiv.
@Sergey Sharybin (sergey) committed the opensubdiv shader and @Jacques Lucke (JacquesLucke) the Python examples.

The documentation part seems fine.

The OpeSubdiv is not currently in use and likely have other issue. Commented on mistake in this shader anyway.

intern/opensubdiv/shader/gpu_shader_opensubdiv_fragment.glsl
68

To my knowledge input and output are reserved keywords in the language. This is a reason why input is called inpt. So here it should be outpt.

73

outpt.FragColor = diffuse;

167

Similar to above.

convert all gl_FragColor variables to FragColor