Page MenuHome

Support packing UDIM textures
Needs RevisionPublic

Authored by Lukas Stockner (lukasstockner97) on Dec 29 2019, 3:22 AM.

Details

Summary

This patch deduplicates quite a bit of stuff in image.c, otherwise the
additional complexity from tiles would have been a lot more.

The only thing that's not working yet is packed UDIMs in Cycles with OSL.

As far as I can tell everything works, but to be honest, I'm not very
familiar with how packed images are supposed to behave so some more
testing would probably be a good idea.

Diff Detail

Repository
rB Blender
Branch
udim_pack (branched from master)
Build Status
Buildable 6120
Build 6120: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested changes to this revision.Thu, Jan 2, 3:24 PM

Please split refactor of image.c to a separate patch, so then it can also be applied separately. That helps reviewing and maintaining code when we know that there are no functional changes expected to happen.

intern/cycles/render/nodes.cpp
514

This 1001 should become a constant, in both Cycles and Blender side, with an explanation why this number is such special.

This revision now requires changes to proceed.Thu, Jan 2, 3:24 PM