Page MenuHome

Fix T71620: broken particle collisions due to rB0666ece2e2f9
ClosedPublic

Authored by Luca Rood (LucaRood) on Sat, Jan 11, 4:02 PM.

Details

Summary

An optimisation in the collision system for cloth (static collisions),
broke the particle collisions, as they take motion into account. This
restores the moving BVH required for the particle collisions, while
keeping the optimisation for the cloth collisions.

Diff Detail

Repository
rB Blender

Event Timeline

Germano Cavalcante (mano-wii) accepted this revision.EditedSun, Jan 12, 3:59 PM

Good to see this problem solved.
I only recommend putting the const qualifier on the new parameter and others that are to read-only (moving_bvh, step and prevstep).

Just a reminder when pushing: The branch for blender 2.82 is blender-v2.82-release (if it's safe, commit to this and then merge into master).

This revision is now accepted and ready to land.Sun, Jan 12, 3:59 PM

Addressed mano-wii's notes and fixed swapped current_x and current_xnew