Page MenuHome

Sculpt: Crease brush: Pinch perpendicular and new defaults
AcceptedPublic

Authored by Pablo Dobarro (pablodp606) on Jan 15 2020, 4:13 PM.

Details

Summary

This patch adds the same code to pinch only in the direction perpendicular to the stroke that is in D6587 to the crease brush.
I also updated the defaults to have something that matches better this new behavior.

Diff Detail

Repository
rB Blender
Branch
brush-perpendicular-falloff (branched from master)
Build Status
Buildable 6692
Build 6692: arc lint + arc unit

Event Timeline

  • Rebase
  • Review update

@Jeroen Bakker (jbakker) I applied the same changes of the revision in D6587 to this patch. The code is the same.

Overall looks good to me, just some small code style remarks.

source/blender/editors/sculpt_paint/sculpt.c
2905

This seems like that this functions has been moved. I didn't see any code differences. Is this OK?

3455

Bit of a code style question. Is it useful to duplicate this code. I can imagine it is.

This revision is now accepted and ready to land.Thu, Mar 19, 9:55 AM