Page MenuHome

Make deps: Fix zlib symbols defined twice
ClosedPublic

Authored by Sergey Sharybin (sergey) on Tue, Jan 21, 10:47 AM.

Details

Summary

We compile zlib as own dependency, but are not informing BLOSC
to use it. This leads to zlib symbols defined twice when linking
Blender: one set comes from libz.a and another one from libblosc.a.

Tested on Linux Debian testing and CentOS 7.5.

It is possible that this change on its own will lead to linking
errors after libraries are re-compiled, This will be fixed as
a dedicated fix to Blender's build system.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) planned changes to this revision.Tue, Jan 21, 10:47 AM

Makes sense to me…

This revision is now accepted and ready to land.Tue, Jan 21, 3:48 PM

We currently have a related issue in the macOS libs, in that Blosc was compiled
with an external LZ4 library and fails to build on buildbot.

In the process of fixing that, I noticed that there is actually no
PREFER_EXTERNAL_ZLIB in Blosc 1.5 yet, so this patch will not work.

As a solution, this patches Blosc 1.5 to have an PREFER_EXTERNAL_ZLIB and not
use external LZ4. When we upgrade to a newer version of Blosc again, we can
remove this part of the patch and it should continue to work.