Page MenuHome

UI: Highlight Selected Enum
Needs RevisionPublic

Authored by Harley Acheson (harley) on Jan 23 2020, 2:02 AM.

Details

Summary

William asked me to resubmit. This patch highlights the currently-selected item in emum lists.

It changes them from the behavior shown at the top-left here to top-right. The hover highlight is lower intensity, the currently-selected gets the stronger highlight. Overall the behavior matches that found throughout the interface, including toggle buttons, Outliner, etc.

The four samples in the bottom of the image are other ideas we have tried and explored. None of the other options worked as well to show the most important part: what is already selected. The multiple columns of icons were distracting. And the right-side indications didn't work at all with multicolumn lists.

Following is another capture, showing the Editor list:

Diff Detail

Repository
rB Blender

Event Timeline

William Reynish (billreynish) accepted this revision.EditedJan 23 2020, 7:48 AM

I think this is a reasonable solution, that is nice and straight forward. It doesn’t rely on an extra icon, which means it works ok with our many icon-ridden enum menus.

This revision is now accepted and ready to land.Jan 23 2020, 7:48 AM

I'm a bit torn with this. I like the idea of indicating the active value. The strong blue highlight does feel a bit weird though, but maybe it's just a matter of getting used to it. I noticed other apps don't seem to indicate the active value either (at least the ones I tried here on Linux). So having one is already unusual, and with the blue highlight it may seem off to some people.

Nevertheless I do think this could be an improvement, just not sure if I like the proposed approach. @Pablo Vazquez (pablovazquez) what's your view?

Updating to current state of master.

Julian Eisel (Severin) requested changes to this revision.Feb 28 2020, 12:29 PM

Checked on this together with @Pablo Vazquez (pablovazquez). He likes the change and I also like it more and more. It does take a moment to get used to it, but it's totally worth it ;)

However (tm), when accepting this design change, we should also make sure to apply it consistently. It does not work in many common cases. In these it also still uses the old blue highlight for hovering, it should use the grey one instead.
E.g. it should be made to work in the following cases:

  • Object mode menu
  • Pulldown menus should use the grey highlight
  • Same for modifier and constraint list
  • ID-template
  • Splash
  • Tool selection popup

So the idea of this patch I'd consider accepted, but more work is needed to adapt it.

This revision now requires changes to proceed.Feb 28 2020, 12:29 PM

@Julian Eisel (Severin) - He likes the change and I also like it more and more. It does take a moment to get used to it...

Yes, the more I use it the more I expect the behavior.

it should be made to work in the following cases:
Object mode menu

If we wait for me to fix that one I think it would be forever. That "Object Mode" menu is not enum, not menu, but appears to be some hard-coded thing. It could be some simple fix, but I can't figure that one out.

In these it also still uses the old blue highlight for hovering, it should use the grey one instead

  • Pulldown menus should use the grey highlight
  • Same for modifier and constraint list
  • ID-template
  • Splash
  • Tool selection popup

I don't understand this part. What is shown for hover highlight for the above list is just one theme setting (Menu Item, Inner Selected). So that is easily changed, but is the color I am using here to indicate selected enum. So are are you asking for a separate theme item? Just not sure what you are asking for as we've been pretty happy for a long time having a different hover color on menus versus everywhere else.