Page MenuHome

Fix T67654: missing ui refresh when changing active particle system
AbandonedPublic

Authored by Jacques Lucke (JacquesLucke) on Jan 28 2020, 1:30 PM.

Details

Summary

Honestly, I don't really understand why this fixes the issue. I thought,
passing NC_OBJECT to RNA_def_property_update would have the same effect.

Diff Detail

Repository
rB Blender
Branch
fix-particle-settings-refresh (branched from master)
Build Status
Buildable 6413
Build 6413: arc lint + arc unit

Event Timeline

source/blender/makesrna/intern/rna_object.c
1009

Also on shaky ground...
WM_main_add_notifier(prop->noteflag, ptr->owner_id); seems to be called in rna_property_update with the right ID even without this patch...

Anyways, even if in uncertainty:
WM_main_add_notifier(NC_OBJECT, ptr->owner_id); should be enough?

will check a bit more...

source/blender/makesrna/intern/rna_object.c
1009

Seems like the ND_DRAW in RNA_def_property_update(prop, NC_OBJECT | ND_DRAW, "rna_Object_particle_update") somehow prevents the ui refresh

source/blender/makesrna/intern/rna_object.c
1009

Problem was more in buttons_area_listener, so suggest to use D6702 instead?

Jacques Lucke (JacquesLucke) added inline comments.
source/blender/makesrna/intern/rna_object.c
1009

Thanks for checking this in more detail. Your patch seems to be better.