Page MenuHome

Cleanup: File Naming Use "utils" instead of "util"
Needs ReviewPublic

Authored by Laurent Noel (c2ba) on Fri, Feb 7, 5:28 PM.

Diff Detail

Repository
rB Blender
Branch
cleanup_filename_util (branched from master)
Build Status
Buildable 6540
Build 6540: arc lint + arc unit

Event Timeline

Revert changes on extern/ files

Rebase on master

Campbell proposed this in T73586 so I'll leave it to check if this matches the intention.

This is missing updates to the header guards (e.g. __BLI_PATH_UTIL_H__), those should match the filename.

Update header guards to match file names

Please don't.
Refactors like this are a huge annoyance for people maintaining branches and patches that haven't been merged yet. I don't see how replacing "util" with "utils" is supposed to be an improvement, the only thing it does is create a lot of unnecessary work and noise in the git history.

Please don't.
Refactors like this are a huge annoyance for people maintaining branches and patches that haven't been merged yet. I don't see how replacing "util" with "utils" is supposed to be an improvement, the only thing it does is create a lot of unnecessary work and noise in the git history.

I understand the point, well it didn't take much time since I scripted most of the changes so I let the devs with commit rights to decide if they want to take or reject it. However it would be great if next time a bit a discussion occurs on the task thread https://developer.blender.org/T73586 to express concerns regarding some items of the list before someone pick them.