Page MenuHome

UI Papercut: Alignment of transformation locks in 3D View Sidebar
Changes PlannedPublic

Authored by Asher (ThatAsherGuy) on Sun, Feb 9, 6:13 PM.

Details

Reviewers
None
Group Reviewers
User Interface
Summary

There is a minor inconsistency in how the transformation locks are aligned in the sidebar, compared to the properties editor. Where the properties editor uses a fixed-width column of lock icons, the sidebar uses split layout. Here's a comparison shot of what this patch does:

This patch isn't 100% feature-complete. I need to make the tweaked layout more translation-friendly, and I need a more deliberate choice of icons for the four-component editing toggle (for quat and axis-angle rotation). I'd appreciate feedback on the latter, especially, as icons aren't my usual wheelhouse and the if-statement I'm using to swap the icon is less than elegant.

Diff Detail

Repository
rB Blender

Event Timeline

Asher (ThatAsherGuy) planned changes to this revision.Sun, Feb 9, 6:13 PM
Asher (ThatAsherGuy) created this revision.

Improving the icon for four-component editing could be done as a separate patch?

That is a rather obscure feature. It basically switches between locking euler angles, or locking the quaternion components. There is no way to properly communicate that in an icon, it's probably better to turn that in a checkbox with text or an enum.

When locking Euler angles, it's rather wrong to display the lock icons next to the values, because they aren't the values that are actually being locked.

Is there a reason why this panel is in C and not Python?

Not all variations of this panel need it, but for some like edit mode it computes the average vertex position, which is done in C.

We could create a '4L' icon, to match the label we currently use. The icon I'm using in this revision is way too generic:

Would it make more sense to put the toggle in the same row as the rotation mode drop-down?

We could create a '4L' icon, to match the label we currently use. The icon I'm using in this revision is way too generic:

I would just keep it text as is, not sure why making a 4L icon helps?

Would it make more sense to put the toggle in the same row as the rotation mode drop-down?

I'd just keep it in the same position, since we usually try to make buttons only affect other buttons below.

Using a label breaks convention and messes with the column alignment. I could try to hack something together, but this is a situation where adding an icon would be easier than wrestling with the layout engine.