Page MenuHome

Fix T73774: Error in Paint 'Clone from Image/UV Map' panel
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Thu, Feb 13, 3:22 PM.

Details

Summary

This panel is not for 2D paint, IMAGEPAINT_PROJECT_LAYER_CLONE is only ever used in projection painting, not 2D painting.
Add a proper poll for this.

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Fri, Feb 14, 1:19 AM
Campbell Barton (campbellbarton) requested changes to this revision.EditedFri, Feb 14, 7:44 AM

The object check should be restricted to settings.mode == 'MATERIAL' case, since this panel is also for 2D image painting.

This revision now requires changes to proceed.Fri, Feb 14, 7:44 AM

The object check should be restricted to settings.mode == 'MATERIAL' case, since this panel is also for 2D image painting.

settings.mode == 'IMAGE' also requires a mesh object...? or does this work without UVs? checking again...

In fact, after checking more, this whole panel is useless in 2D paint, IMAGEPAINT_PROJECT_LAYER_CLONE is only ever used in ... well projection painting, not 2D painting...
I mean, I guess it could be supported in 2D as well, but this is outside the scope of this fix.
Will update diff accordingly...

In that case the PAINT_2D check should be removed.

remove panel from 2D paint entirely

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Feb 14, 11:14 AM
This revision was automatically updated to reflect the committed changes.