Page MenuHome

Rendering workspace: Slot, View Layer & Combined drop downs, displaying label before data
Needs RevisionPublic

Authored by Adrian Newton (TFS) on Fri, Mar 13, 3:28 PM.

Details

Summary
  1. Render Default Cube.
  2. Go to Rendering workspace.
  3. Select either the Slot1, View Layer or Combined drop downs.

You should get this:

If you flip the header to the bottom, you get this:

I have looked around and the issue lies in Blender\Editors\space_image\image_buttons.c

This Diff resolves this particular, within this workspace, and brings it into line with the rest of Blender.

Additionally, the Slot information is displayed in Slot 8 -> Slot 1 order. If it would be better in the order of Slot 1 -> Slot 8, let me know and i'll submit another patch.

Diff Detail

Event Timeline

I have included another diff to change the Rendering Slot drop down, Slot order if it's a desired change.

Rendering workspace: Render Slot order - current:

Rendering workspace: Render Slot order - proposed:

Diff:

Not sure why these were flipped, but yes, it should be consistent.

Also we should order the slots sequentially, yes.

This revision is now accepted and ready to land.Tue, Mar 17, 7:57 PM
Brecht Van Lommel (brecht) requested changes to this revision.Thu, Mar 19, 8:45 PM

This still isn't quite right I think? The label is supposed to be furthest away from the mouse cursor like other enum menus.

This revision now requires changes to proceed.Thu, Mar 19, 8:45 PM

I could be wrong, but I think the only thing needed is the "other" patch, pasted into the first comment, that puts the slots in ascending order.

That we put the "headers" for these enums at the end might seem a bit weird but is how we do it all over the place. Personally I'd rather it not shown at all most of the time, but that is another issue. LOL

Brecht.

The patch covers the movement of the Label to the appropriate location, and the further attached diff (Render Slot reorder - proposed.diff) covers the reorder of the Slot numbers.
I attached it separately as I wasn't sure both changes would be accepted together as a single diff.