Page MenuHome

Fix T74780: Face sets operators not aware of SCULPT_FACE_SET_NONE
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Thu, Mar 19, 9:17 PM.

Details

Summary

SCULPT_FACE_SET_NONE default value is 0 and it is rendered hidden, so
the invert sign operation to show it was not working. Now the show all
function sets this face set to ID 1 before setting its sign.

I also refactored this check in gpu_buffers.

Not related to the reported issue, but the mesh in attached contains non
manifold geometry with hidden loose vertices, so the visibility state
was not syncing correctly to those vertices. Now the toggle operators
checks the current visibility only on the face sets, so no manifold
vertices are ignored (as they are in the rest of operations in sculpt
mode).

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
296

Perhaps add a comment for this one. It isn't clear why this is done.

This revision is now accepted and ready to land.Thu, Mar 26, 9:40 AM