Page MenuHome

Fix T74744: Studio Lights editor not updating in realtime when tweaking the settings
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Fri, Mar 20, 1:08 PM.

Details

Summary

Caused by rBc476c36e4008.

This hooks into the existing FIXME (workaround for a missing update
tagging), reactivates the NS_VIEW3D_GPU notifier (introduced in
rB2ad3d8f158d2 -- but not going anywhere atm.) to check changes to rv3d-

rflag which indicated UserStudioLight has changed. To not have updates

all the time, the rflag also needs to be cleared again (see original
rB2ad3d8f158d2), this is now done in 'workbench_draw_finish'.

While this fix works, we have a couple of related reports, namely T74957,
T74872 where the notifiers are not working reliably. Not sure if there is
a more general fix?

Diff Detail

Repository
rB Blender

Event Timeline

Clément Foucault (fclem) requested changes to this revision.Mon, Mar 23, 6:51 PM
Clément Foucault (fclem) added inline comments.
source/blender/draw/engines/workbench/workbench_data.c
214

Put the rv3d->rflag &= ~RV3D_GPULIGHT_UPDATE; here.

This revision now requires changes to proceed.Mon, Mar 23, 6:51 PM
Philipp Oeser (lichtwerk) marked an inline comment as done.Mon, Mar 23, 9:39 PM
This revision is now accepted and ready to land.Mon, Mar 23, 9:47 PM
Clément Foucault (fclem) requested changes to this revision.Mon, Mar 23, 9:47 PM
Clément Foucault (fclem) added inline comments.
source/blender/draw/engines/workbench/workbench_data.c
213

check if rv3d is valid before doing so.

This revision now requires changes to proceed.Mon, Mar 23, 9:47 PM
  • check if rv3d is valid
This revision is now accepted and ready to land.Mon, Mar 23, 11:11 PM