Page MenuHome

Add new simulation data block
AcceptedPublic

Authored by Jacques Lucke (JacquesLucke) on Tue, Mar 24, 2:59 PM.

Details

Summary

This introduces a new id data block with type ID_SIM.

The RNA part of this change is disabled by default for now.
The corresponding cmake option is WITH_SIMULATION_DATA_BLOCK_RNA.

The new data block does not yet have an embedded node tree.
I want to add that separately.

This is part of T73324.

The set of files I changed is based on rBb0a1cf2c9ae696.
However, I had to change fewer files, because I did not add a new object type.

Diff Detail

Repository
rB Blender
Branch
simulation-data-block (branched from master)
Build Status
Buildable 7285
Build 7285: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Tue, Mar 24, 4:14 PM

Looks fine overall.

CMakeLists.txt
327

I would recommend naming this WITH_NEW_SIMULATION_TYPE, in case it needs to be checked in more places than RNA later.

source/blender/blenkernel/intern/lib_remap.c
526 ↗(On Diff #23059)

Not needed here, this is not used as object data.

source/blender/editors/animation/anim_channels_defines.c
3053

VO -> SIM

This revision now requires changes to proceed.Tue, Mar 24, 4:14 PM
  • rename WITH_SIMULATION_DATA_BLOCK_RNA to WITH_NEW_SIMULATION_TYPE
  • remove unnecessary case in lib_remap.c
  • replace VO_DS_EXPAND with SIM_DS_EXPAND
This revision is now accepted and ready to land.Tue, Mar 24, 5:06 PM