Page MenuHome

Sculpt: Pose Brush Face Sets origin mode
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Wed, Mar 25, 11:31 PM.
Tags
None
Tokens
"Love" token, awarded by mistajuliax."Love" token, awarded by ILJI."Love" token, awarded by RC12."Love" token, awarded by TheFlow."Like" token, awarded by julperado."Love" token, awarded by Zino."100" token, awarded by EitanSomething."100" token, awarded by jmztn."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by RodDavis.

Details

Summary

This commit introduces a new mode for calculating the positions and
weights of the IK segments in the Pose Brush based on the Face Sets.

The first segment of the chain will always include all face sets inside
the brush radius and it will propagate until the boundary of the last
face sets added in the flood fill. Then consecutive connected face sets
are added to the chain until the chain length limit is reached or all
face sets of the mesh are already part of the chain.

This feature enables complete control over the pose brush origins in
case that is needed. Also, with this mode, the user can have a library
of base meshes with face sets already configured to get to the initial
pose as fast as possible.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Thu, Mar 26, 10:19 AM

LGTM, just some small remarks on naming

source/blender/editors/sculpt_paint/sculpt.c
200–201

Can we use ELEM here?

source/blender/makesdna/DNA_brush_types.h
295

In stead of AUTOMATIC should we use Topology, automatic doesn't tell the user or developer anything

This revision now requires changes to proceed.Thu, Mar 26, 10:19 AM
Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • Review update
This revision is now accepted and ready to land.Fri, Mar 27, 8:24 AM