Page MenuHome

Strengthen existing modifiers test validation
ClosedPublic

Authored by Jesse Y (deadpin) on Apr 10 2020, 9:58 PM.

Details

Summary

In preparation for merging in at least 1 outdated test into the new modifiers suite, and strengthening the existing coverage, we need to start validating that the mesh geometry is valid by calling mesh.validate (aka. BKE_mesh_validate)

While working on this change it's already caught a problem with Bevel (T74800) and a similar unreported issue with Weld (both had vertex weights > 1.0 and in the case of Weld it was 2.0). The fix for 74800 seems to have fixed both so this change can now proceed.

This patch also forces the python output to be flushed after each call. This is necessary in general so that python and blender output appear in the correct order during the test.

Tested locally with Debug and RelWithDebInfo configurations.

Diff Detail

Repository
rB Blender
Branch
cleanup (branched from master)
Build Status
Buildable 7541
Build 7541: arc lint + arc unit

Event Timeline

Jesse Y (deadpin) requested review of this revision.Apr 10 2020, 9:58 PM
Jesse Y (deadpin) created this revision.

Although this goes slightly beyond the strict definition of a regression test, I think it's useful to double check the newly updated geometry is valid.

This revision is now accepted and ready to land.Apr 10 2020, 11:29 PM

Hi @Howard Trickey (howardt), any thoughts on this? Could you commit it if it look fine to you?

I submitted this with commit a93ed3bcb7910