Page MenuHome

Simplify the modal solver Ceres cost function
ClosedPublic

Authored by Keir Mierle (keir) on Aug 22 2014, 8:47 AM.

Details

Summary

Fix test by flipping the quaternion.

Diff Detail

Repository
rLMV Libmv

Event Timeline

Keir Mierle (keir) retitled this revision from to Simplify the modal solver Ceres cost function.Aug 22 2014, 8:47 AM
Keir Mierle (keir) updated this object.
Keir Mierle (keir) updated this revision to Diff 2476.
Sergey Sharybin (sergey) accepted this revision.

Code seems to be fine, but might be missing some obvious type or so. Assume you run make test and there's no typos :)

This revision is now accepted and ready to land.Aug 22 2014, 9:58 PM
Keir Mierle (keir) updated this object.
Keir Mierle (keir) updated this revision to Diff 2498.

Fix test by flipping the quaternion.

That's a bit weird. Can we make it so we don't do anything blender-specific in here from the Libmv side and i'll look into flipping some matricies in blender's c-api?

This revision was automatically updated to reflect the committed changes.