Page MenuHome

Minor keyframe selection cleanups
ClosedPublic

Authored by Keir Mierle (keir) on Aug 22 2014, 8:50 AM.

Diff Detail

Repository
rLMV Libmv

Event Timeline

Keir Mierle (keir) retitled this revision from to Minor keyframe selection cleanups.
Keir Mierle (keir) updated this object.
Sergey Sharybin (sergey) edited edge metadata.

Seems fine, just could worth moving PseudoInverseWithClampedEigenvalues() to a more generic place. Don't have strong opinion on this tho.

src/libmv/simple_pipeline/keyframe_selection.cc
89–90

What about moving to numeric or adding a TODO about considering moving it?

This revision is now accepted and ready to land.Aug 22 2014, 10:01 PM
Keir Mierle (keir) updated this revision to Diff 2483.

Closed by commit rLMVd976e034cdf7 (authored by @Keir Mierle (keir)).