Page MenuHome

VSE: Add Select Neighboring handles
AcceptedPublic

Authored by Peter Fog (tintwotin) on Tue, May 12, 5:14 PM.

Details

Summary

This patch add the missing select neighboring handles functions(gif):

These functions are essential for adding the missing Strip Slide and Split Roll trim functions, which now can be implemented easily after this Select Neighboring Handles patch is committed.

Not part of this patch(as single functions)
Strip Slide(gif):

Split Roll(gif):

Added shortcuts:
J, K, L + alt is select inside handles.
J, K, L + alt + Ctrl is select neighbor handles.

Unhide and unlock changed to use ctrl instead of alt(they should both be converted to toggles at some point)).

Diff Detail

Event Timeline

Peter Fog (tintwotin) requested review of this revision.Tue, May 12, 5:14 PM
Peter Fog (tintwotin) created this revision.
Richard Antalik (ISS) requested changes to this revision.Thu, May 14, 1:26 AM

There is a problem, that you are looping and operating over strips that have seq->flag & SELECT set. If you set this flag to strip that has not yet been looped over, it will be considered as if it has been selected before you started operator.

I guess easiest fix is to ony set SEQ_LEFTSEL and SEQ_RIGHTSEL flags and loop over strips again where you would finally select them.

This revision now requires changes to proceed.Thu, May 14, 1:26 AM

Moved strip selection loop out of handle selection loop.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

Cleaned up the code a bit and added shortcuts:
Select Left handle = [ + shift
Select Right Handle = ] + shift
Select Both Handles= EQUAL + shift

Select Left Neighbor Handle = [ + shift
Select Right Neighbor Handle = ] + shift
Select Neighbor Both Handels = EQUAL + shift

[ and ] are already used for selecting on either side of the playhead, so when select Under is committed the shortcut should be Equal.

Equal used to be assigned to Insert Gap, this has now been assigned Backspace + Ctrl.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Tue, May 19, 3:39 PM
Peter Fog (tintwotin) updated this revision to Diff 24939.EditedTue, May 19, 7:53 PM
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

Remove the shortcuts again, as the brackets also are used in extended state(+shift).

I can't find a triangle of keys with +shift free to use, so I'll leave the shortcut keys out of this patch.

Richard Antalik (ISS) requested changes to this revision.Wed, May 20, 3:45 PM

This seems to work ok.

You have removed changes from space_sequencer.py so there isn't menu items for this feature.

source/blender/editors/space_sequencer/sequencer_edit.c
105–107

There is problem that this enum is alsu used for split and select_side operator.

I think all 3 operators should have only items available that are implemented. I am probably guilty here as well, because I haven't noticed in past.

This revision now requires changes to proceed.Wed, May 20, 3:45 PM
Peter Fog (tintwotin) updated this revision to Diff 25031.EditedSat, May 23, 11:11 AM

Reinserted the menu options.
Added shortcuts:
J,K,L + alt is select inside handles.
J,K,L + alt is select neighbor handles.

Unhide and unlock changed to use ctrl instead of alt(they should be converted to toggles at some point)).

Need instructions on what to do about the enum?

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

A hunk of code was missing in previous patch.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Tue, May 26, 5:47 AM
Richard Antalik (ISS) requested changes to this revision.Tue, May 26, 8:38 PM

I think I would accept this, but I am quite confused about shortcuts:

  • They don't work when I checked.
  • K and L key is already assigned. Changing K shortcut may cause quite a problem because I imagine it is most used shortcut.
  • Unrelated changes (mute)

I think best approach would be to commit without keymap changes

This revision now requires changes to proceed.Tue, May 26, 8:38 PM

It's fine with me, if you want to commit this without the shortcut keys, but at some point before the next release, we must deal with all of the missing shortcuts in the Sequencer.

It's fine with me, if you want to commit this without the shortcut keys, but at some point before the next release, we must deal with all of the missing shortcuts in the Sequencer.

Ah sorry I missed the alt modifier. Will check again. I will have to commit with changes anyway because of enum I mentioned in inlines.

This revision is now accepted and ready to land.Wed, May 27, 12:12 AM