Page MenuHome

Fix T76776: Implement vertex_visibility_get for PBVH_GRIDS
Needs ReviewPublic

Authored by Pablo Dobarro (pablodp606) on Thu, May 21, 12:10 AM.

Details

Summary

This was missing from when Face Sets were enabled in Multires, so it was
always considering that all vertices in the grids are visible. This
should also fix other unreported bugs.

Diff Detail

Repository
rB Blender
Branch
T76776 (branched from master)
Build Status
Buildable 8144
Build 8144: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Thu, May 21, 12:10 AM
source/blender/blenkernel/BKE_pbvh.h
232

PBVH *pbvh

Although, it 's a mess here already, bvh and pbvh are used interchangeably. Should convolve to pbvh. Better to do as a separate change, before or after this one.

source/blender/editors/sculpt_paint/sculpt.c
262

Checking for grid_index seems weird to me. The very first grid (which will have index 0) will not be checked here?