Page MenuHome

Remove Threaded Sculpt option
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Jun 8 2020, 10:06 PM.

Details

Summary

Threaded Sculpt is now always enabled by default. If it causes
performance problems compared single threaded sculpt it should be
considered a bug.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Jun 8 2020, 10:06 PM
Pablo Dobarro (pablodp606) created this revision.
Sergey Sharybin (sergey) requested changes to this revision.Jun 9 2020, 9:44 AM

use_threading argument of BKE_pbvh_parallel_range_settings is always truth, remove it.

source/blender/editors/sculpt_paint/paint_vertex.c
2174

You can not use flag which is marked as UNUSED.

This revision now requires changes to proceed.Jun 9 2020, 9:44 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.Jun 9 2020, 6:24 PM

@Sergey Sharybin (sergey) It is false in some parts of dyntopo and in the cloth brush

It is false in some parts of dyntopo and in the cloth brush

Allright then.

This revision is now accepted and ready to land.Jun 10 2020, 9:36 AM
This revision was automatically updated to reflect the committed changes.