Page MenuHome

Fix T77764: VSE: snap strip to current frame does not move associated effect strips keyframes along
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Jun 11 2020, 4:53 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jun 11 2020, 4:53 PM
Philipp Oeser (lichtwerk) created this revision.
Richard Antalik (ISS) added inline comments.
source/blender/editors/space_sequencer/sequencer_edit.c
1420–1428

seq->startofs + seq->startstill - seq->start could be replaced with seq->startdisp
also (a - b) + c is same as a - b + c

If you don't object to this I will commit with this change

This revision is now accepted and ready to land.Jun 16 2020, 4:08 PM
source/blender/editors/space_sequencer/sequencer_edit.c
1420–1428

This is taken from a few lines above:
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_sequencer/sequencer_edit.c$1380

I wasnt 100% sure to use seq->startdisp since BKE_sequence_calc / BKE_sequence_calc_disp is called again after [so not totally positive this is up-to-date here in all cases -- looks like it should, but was more like "better safe than sorry"]

If we change it in this patch, maybe change above as well?
In either case, I can commit as well, just give me a wink if you really want this changed.

source/blender/editors/space_sequencer/sequencer_edit.c
1420–1428

BKE_sequence_calc shouldn't touch seq->seq1/2/3->anything.

seq->startdisp is more readable so I would prefer that. This value must be up to date at least before operator is called. I would just double check before committing. Wouldn't mind changing even that line above.