Page MenuHome

Fix T78880: UV Editor - Match prop edit connected behavior with mesh editing and fix Rip Region double proportional checkbox
ClosedPublic

Authored by Sebastian Parborg (zeddb) on Jul 14 2020, 12:14 PM.

Details

Summary

This fixes the double prop edit checkbox in the redo menu.

This also makes it so that proportional edit in connected mode now matches how it behaves in mesh edit mode.
Without this change, ripping in UV edit mode with proportional edit on would be useless as the UV verts you ripped will still be stuck together even if they were not connected anymore.

Diff Detail

Repository
rB Blender

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Jul 14 2020, 12:14 PM
Sebastian Parborg (zeddb) created this revision.

Made sure to clear the loop elem tags before using them in the distance calc func

Great to have this functionality, in general LGTM, minor comments only.

source/blender/editors/mesh/editmesh_utils.c
781

While this is some personal taste, I don't find these variables help all that much with readability, I think the code would read OK without them.

If you want to keep them though, suggest to make them const bool's and assign once.

source/blender/editors/transform/transform_convert_mesh_uv.c
98

Picky - use full sentences.

148

con abbreviation is a bit ambiguous (could use connected or adjacent).

231

picky (again sentences)

This revision is now accepted and ready to land.Jul 14 2020, 4:25 PM

I spent some more time on this and figured out what was tagging the loops.
There was a stray loop tag in createTransUVs.

I also added some more assert checks to make sure that the loop tag state is clean.

Thanks for the review! :)