Page MenuHome

Fix T78920: missing depsgraph relation when using sound strips in VSE
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Jul 14 2020, 4:32 PM.

Details

Summary

This fixes the error shown in T78920.

The removal of no-op relations removes the relation again, so there is no
actual change in the resulting dependency graph. The error message is gone
though.

Diff Detail

Repository
rB Blender

Event Timeline

Sybren A. Stüvel (sybren) requested review of this revision.Jul 14 2020, 4:32 PM

Don't think this s is correct. SOUND_EVAL is more of an exit operation, which might depend on the volume (and possibly, other nodes).

I added an AUDIO_ENTRY node to have an explicit entry node.

This does result in a double relation AUDIO_ENTRYAUDIO_VOLUME, which is caused by the fact that DepsgraphRelationBuilder::build_scene_audio(scene) is called multiple times for the same scene (once when building the scene, and once when building the sequence editor). This issue was already there before this patch, though, in the doubling of the AUDIO_VOLUMESOUND_EVAL relation.

This revision is now accepted and ready to land.Jul 16 2020, 11:43 AM