Page MenuHome

UI: Add auto keyframing popover
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Aug 11 2020, 2:52 PM.
Tokens
"Love" token, awarded by weasel."Like" token, awarded by ChrisLend."Love" token, awarded by gilberto_rodrigues."Like" token, awarded by AndyCuccaro."Like" token, awarded by jorsh.

Details

Summary

For other areas in Blender that have a toggle and related settings we put a popover with the settings right next to the toggle.

This combination is nice because it organizes the settings without making interaction slower.
It also makes the settings more discoverable since they're right next to the toggle.

BeforeAfter

Diff Detail

Repository
rB Blender
Branch
timeline-auto-keyframing-popover (branched from master)
Build Status
Buildable 9462
Build 9462: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Aug 11 2020, 2:52 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) retitled this revision from For other areas in Blender that have a toggle and related settings we put a popover with the settings right next to the toggle. to UI: Add auto keyframing popover.Aug 11 2020, 2:54 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) retitled this revision from UI: Add auto keyframing popover to For other areas in Blender that have a toggle and related settings we put a popover with the settings right next to the toggle..
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
  • Deactivate the popover button when auto keframing is off
Hans Goudey (HooglyBoogly) retitled this revision from For other areas in Blender that have a toggle and related settings we put a popover with the settings right next to the toggle. to UI: Add auto keyframing popover.Aug 11 2020, 3:26 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Aug 12 2020, 9:32 AM

I wouldnt deactivate the popover button when autokey is off because you might want to change the settings before enabling autokey.

I wouldnt deactivate the popover button when autokey is off because you might want to change the settings before enabling autokey.

You can still edit the settings if the button is inactive, it just means it's grayed out. We do the same for the 3D view's popovers.

Oh yeah I do find it a bit confusing , but consistent. but confusing.

Sebastian Parborg (zeddb) added inline comments.
release/scripts/startup/bl_ui/space_time.py
40

Trailing whitespace.

Other than my nitpick whitespace comment, LGTM.

This revision was automatically updated to reflect the committed changes.