Page MenuHome

UI: Add menu to ID-template for library operations
Needs ReviewPublic

Authored by Julian Eisel (Severin) on Aug 12 2020, 6:37 PM.

Details

Summary

For linked or overriden data-blocks, show a menu with operations:

  • Make Local (regular make local or remove the override and make local)
  • Add Library Override

These options were available before as a icon to click on. But to create a library override there was a hack so you could Shift-click it, which is wasn't meant as final solution in the first place.
A menu makes things more discoverable and scales better (more operations can be added).

Also:

  • Use the red "disabled hint" in tooltips to explain why buttons are disabled, rather than using the regular tooltip text for that. That is the consistent way to do that now.
  • Show library link status icon in the ID-template text button. Useful to indicate that something is a linked data-block.


(Should probably read "cannot be changed", I just kept the old text.)


Updated Screenshots:

Diff Detail

Repository
rB Blender
Branch
temp-template-ui-tweaks (branched from master)
Build Status
Buildable 9692
Build 9692: arc lint + arc unit

Event Timeline

Julian Eisel (Severin) requested review of this revision.Aug 12 2020, 6:37 PM
Julian Eisel (Severin) created this revision.
Julian Eisel (Severin) edited the summary of this revision. (Show Details)Aug 12 2020, 6:53 PM
Julian Eisel (Severin) edited the summary of this revision. (Show Details)
Julian Eisel (Severin) updated this revision to Diff 27734.EditedAug 14 2020, 12:14 PM
  • Merge branch 'master' into temp-template-ui-tweaks

Updated to include fix rBb3165fb8b568.

Also as a note, we could move the other available buttons to the menu. But I'm not too sure about that, since people may want quick access to operations like unlinking, making a single user copy, file opening or unpacking, etc. Also, the fake user button should probably be visible without having to go to the menu, to serve as a reminder.

So it's an option to move more operations to the menu, but I'm not sure about that. So leaving this as a possible future change on top of this.

I think there should be more operators in the menu. At least Delete (which is different than Unlink) and Reset Overrides. I'd even duplicate what's already available as dedicated buttons, to have a consistent and complete menu everywhere. If that menu has the icon + the name of the operation, it may also help users learn the meaning of the quick buttons.

For fake user, unpacking, we could consider moving them in the menu, but still showing the icon when they are enabled. That could be either a button, or a something more subtle in the text field right hand side.

This is more a topic for a design task though.

I think there should be more operators in the menu. At least Delete (which is different than Unlink) and Reset Overrides. I'd even duplicate what's already available as dedicated buttons, to have a consistent and complete menu everywhere. If that menu has the icon + the name of the operation, it may also help users learn the meaning of the quick buttons.

Fully agree here.

Code-wise, I feel a bit sad that we have to keep the hackish template callback function instead of using proper operator buttons/menu entries, but this is a separate topic I think, so otherwise looks good to me.

Julian Eisel (Severin) updated this revision to Diff 27983.EditedThu, Aug 20, 4:43 PM

Many changes to get the following:

  • Add (almost) all operations to the menu
  • Move Library status icon to the right
  • Show user count & fake user icon as pure indicators (non-interactive) on the right

Didn't add proper ID delete and unpack items to the menu yet.


This is becoming a bigger design topic than I hoped it would be. I'll have to discuss
this properly in T78012 or a new task.

Julian Eisel (Severin) edited the summary of this revision. (Show Details)Thu, Aug 20, 5:08 PM