Page MenuHome

Fix T80771: Avoid changing the visibility of loose geometry when entering Sculpt Mode
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Tue, Sep 15, 10:50 PM.

Details

Summary

When entering scultp mode the visibility from the Face Sets is copied to
the base mesh. This steps was considering that if a vertex belongs to a
face with a visibible Face Set ID, it should be visible. As loose
geometry may not have any faces, those vertex were set to hidden.

Now this function check if a vertex visibility should be modified by the
face sets (by checking the loops), avoiding modifying the visibility of
loose geometry unintentionally.

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Tue, Sep 15, 10:50 PM
Pablo Dobarro (pablodp606) created this revision.

Generally fine. See suggestion on the naming.

source/blender/blenkernel/intern/paint.c
1895–1899

visible_face_set reads more like an Id of a visible face set. is_face_set_visible is more explicit and clear.

This revision is now accepted and ready to land.Wed, Sep 16, 9:54 AM