Page MenuHome

UI: Add stack add search menu to properties editor
AcceptedPublic

Authored by Hans Goudey (HooglyBoogly) on Sep 17 2020, 5:08 PM.
Tokens
"Love" token, awarded by RC12."Mountain of Wealth" token, awarded by duarteframos."Love" token, awarded by pablovazquez."Like" token, awarded by Fracture128."Love" token, awarded by Shimoon."Party Time" token, awarded by manitwo.

Details

Reviewers
Pablo Vazquez (pablovazquez)
Group Reviewers
User Interface
Summary

In the spirit of search everywhere, one way to significantly speed up
interaction with modifiers is to allow searching to add them.

This patch adds a context sensitive search menu operator to the relevant
tabs of the properties editor. Another benefit is that this allows adding
modifiers, etc, when you're scrolled down past the "Add Modifier" button.

Two notes about the implemention:

  1. I had to add a check for an empty identifier to the operator search code in order not to display the column separators in the search menu.
  2. This changes the default "invoke" action for the relevant operators to the search menu. This seems fine to me, but maybe there is a better way to do it.

Diff Detail

Repository
rB Blender
Branch
properties-stack-add (branched from master)
Build Status
Buildable 10495
Build 10495: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Sep 17 2020, 5:08 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/editors/space_buttons/buttons_ops.c
120–122

Comment needs updating to reflect the more generalized nature of this operator.

  • Merge branch 'master' into properties-stack-add

This is crazy awesome! Feels super fast and natural.

One issue I found is that adding a modifier/effect/constraint via the regular menu also triggers the search, when it should just add the corresponding modifier. Other than that for me it's ready to go!

  • Merge branch 'master' into properties-stack-add
  • Add WM_enum_menu_or_search_invoke
  • Add comment
  • Use the new "search or menu" invoke function

Love it! Works just as expected now.

Thanks for working on it!

This revision is now accepted and ready to land.Tue, Oct 13, 5:06 PM