Page MenuHome

Fix Face Set overlay rendering wrong color with modifiers
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Sep 19 2020, 5:19 PM.

Details

Summary

face_set_color_default was not copied when copying meshes, so when
extracting the colors in the draw cache it was using a wrong default
color ID.

Diff Detail

Repository
rB Blender
Branch
fix-wrong-default-face-set-color (branched from master)
Build Status
Buildable 10307
Build 10307: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) requested review of this revision.Sep 19 2020, 5:19 PM

Seems fine.

@Brecht Van Lommel (brecht), a bit "offtopic", but wondering whether you can think of a more clear and robust way of dealing with this.

This revision is now accepted and ready to land.Sep 21 2020, 9:18 AM

Not sure how to prevent these kinds of issues without a big refactor of the mesh data structures.