Page MenuHome

Fix T81884, clamping with percent, addendum.
ClosedPublic

Authored by Howard Trickey (howardt) on Oct 24 2020, 4:49 PM.

Details

Summary

The previous fix forgot the case where there is an intermediate
edge and everything isn't in one plane.

Diff Detail

Repository
rB Blender

Event Timeline

Howard Trickey (howardt) requested review of this revision.Oct 24 2020, 4:49 PM
Howard Trickey (howardt) created this revision.

I can confirm this fixes the bug, and it seems relatively straightforward. Actually it seems a bit odd that percent mode made it so long without changes to offset_on_edge_between.

source/blender/bmesh/tools/bmesh_bevel.c
1540–1557

I guess it's too bad that we still have to run these functions in this special case just to get the angle. But the logic to get the angle is pretty wrapped up in the other logic of offset_meet_edge, so it's probably not worth changing that.

This revision is now accepted and ready to land.Oct 24 2020, 8:35 PM