Fillet Curve Node: Add a point selection input #100031
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#100031
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The node should have a point selection input in order to the limit the effect without having to adjust the "radius" input.
Some hints on the implementation:
IndexMask
from the field evaluatorslice_and_offset
incalculate_result_offsets
to get theIndexMask
local to each curvebNodeSocket
inversioning_300.c
gives some similar code).Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @HooglyBoogly
Added subscriber: @Shan-Huang
Hi there! I was able to make some progress on this (WIP: D16009). A couple of questions:
slice_and_offset
to localize the selection to each curve. To slice and offset, I first need a per-curveIndexRange
to slice with, which seems tricky to compute without looping through the mask multiple times. My current approach is to extract inverse selection ranges and skip filleting the deselected points, which.. could be more efficient. If there's a more elegant way to do it, I'd love to know :)bNodeSocket
pointer inversioning_300
? There are too many occurrences for a total noob like me to make sense of what's going on... @_@. Doc pointers are highly appreciated too!Hey @Shan-Huang, sorry for the late reply.
slice_and_offset
, I think you're right, it's a bit more complicated than I expected. We may have to resort to using boolean arrays, or build one extra array first to store the offset into the selection at the start of each curve (or something like that).dedc679eca
has some examples of versioning changes to node groups. There aren't too many docs about such things though.Let me know if I can answer any other questions.
Sweet. Thanks for the pointers! I've updated the patch and it's ready for review. It's my very first patch so please don't hold back any nits :)
@HooglyBoogly is this issue still open ??
Yes, it's open.
@HooglyBoogly how close is this fix https://archive.blender.org/developer/D16009 with regards to the main one because I was reading through this fix and found a lot of stuff being fixed....
I don't really remember. I'd expect whoever works on this task to do some testing and research to figure that out.
Ohhk I'll look into it then.